smack: Refactor to remove bprm_secureexec hook
authorKees Cook <keescook@chromium.org>
Tue, 18 Jul 2017 22:25:26 +0000 (15:25 -0700)
committerKees Cook <keescook@chromium.org>
Tue, 1 Aug 2017 19:03:07 +0000 (12:03 -0700)
commitccbb6e1065fa9cd27f2bf406e8c5d5cf0273f554
treeabae0a33676b6127a2600827c8fb11d9f3890fa6
parent62874c3adf709b884ceb0c61c35ab3794b3b0e95
smack: Refactor to remove bprm_secureexec hook

The Smack bprm_secureexec hook can be merged with the bprm_set_creds
hook since it's dealing with the same information, and all of the details
are finalized during the first call to the bprm_set_creds hook via
prepare_binprm() (subsequent calls due to binfmt_script, etc, are ignored
via bprm->called_set_creds).

Here, the test can just happen at the end of the bprm_set_creds hook,
and the bprm_secureexec hook can be dropped.

Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Serge Hallyn <serge@hallyn.com>
Reviewed-by: James Morris <james.l.morris@oracle.com>
Reviewed-by: Casey Schaufler <casey@schaufler-ca.com>
security/smack/smack_lsm.c