ipmi/powernv: Fix potential invalid pointer dereference
authorNeelesh Gupta <neelegup@linux.vnet.ibm.com>
Thu, 16 Jul 2015 11:16:54 +0000 (16:46 +0530)
committerCorey Minyard <cminyard@mvista.com>
Thu, 3 Sep 2015 20:01:55 +0000 (15:01 -0500)
commitcca85f19c260df495a487495479c67803b25fa8a
tree91aed5a553ea8a627ac8b60301df2ad57a10cbdf
parent0fbcf4af7c8362d4691f9388efa57d0b14b34225
ipmi/powernv: Fix potential invalid pointer dereference

If the OPAL call to receive the ipmi message fails, then we free up the
smi message and return. But, the driver still holds the reference to
old smi message in the 'cur_msg' which can potentially be accessed later
and freed again leading to kernel oops. To fix it up,

The kernel driver should reset the 'cur_msg' and send reply to the user
in addition to freeing the message.

Signed-off-by: Neelesh Gupta <neelegup@linux.vnet.ibm.com>
Fixed a checkpatch warning dealing with an else after a return.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
drivers/char/ipmi/ipmi_powernv.c