mailbox: skip complete wait event if timer expired
authorSudeep Holla <sudeep.holla@arm.com>
Tue, 21 Mar 2017 11:30:15 +0000 (11:30 +0000)
committerJassi Brar <jaswinder.singh@linaro.org>
Thu, 27 Apr 2017 10:50:04 +0000 (16:20 +0530)
commitcc6eeaa3029a6dbcb4ad41b1f92876483bd88965
tree802adbab75077e90751f4c59ecf8ffaabc4c2737
parentc61b781ee084e69855477d23dd33e7e6caad652c
mailbox: skip complete wait event if timer expired

If a wait_for_completion_timeout() call returns due to a timeout,
complete() can get called after returning from the wait which is
incorrect and can cause subsequent transmissions on a channel to fail.
Since the wait_for_completion_timeout() sees the completion variable
is non-zero caused by the erroneous/spurious complete() call, and
it immediately returns without waiting for the time as expected by the
client.

This patch fixes the issue by skipping complete() call for the timer
expiry.

Fixes: 2b6d83e2b8b7 ("mailbox: Introduce framework for mailbox")
Reported-by: Alexey Klimov <alexey.klimov@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
drivers/mailbox/mailbox.c