r8169: fix potential skb double free in an error path
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 5 Nov 2020 14:28:42 +0000 (15:28 +0100)
committerJakub Kicinski <kuba@kernel.org>
Sat, 7 Nov 2020 20:10:16 +0000 (12:10 -0800)
commitcc6528bc9a0c901c83b8220a2e2617f3354d6dd9
tree141d253268458cd855e1fa7d882014e837a418f5
parent86bbf01977b4fdfffc8cab46e398ff279380b194
r8169: fix potential skb double free in an error path

The caller of rtl8169_tso_csum_v2() frees the skb if false is returned.
eth_skb_pad() internally frees the skb on error what would result in a
double free. Therefore use __skb_put_padto() directly and instruct it
to not free the skb on error.

Fixes: b423e9ae49d7 ("r8169: fix offloaded tx checksum for small packets.")
Reported-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/f7e68191-acff-9ded-4263-c016428a8762@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/realtek/r8169_main.c