cgroup: fix exit() vs rmdir() race
authorLi Zefan <lizefan@huawei.com>
Thu, 24 Jan 2013 06:43:28 +0000 (14:43 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 3 Mar 2013 22:09:07 +0000 (06:09 +0800)
commitcc0e3e13b0a90e5ff42d5b134939eacf5e7e497c
tree9c755b28f50082b772b96ee2b14514f977f8f031
parent6403d47ff9392807fcfa4464527193e0cab65b2a
cgroup: fix exit() vs rmdir() race

commit 71b5707e119653039e6e95213f00479668c79b75 upstream.

In cgroup_exit() put_css_set_taskexit() is called without any lock,
which might lead to accessing a freed cgroup:

thread1                           thread2
---------------------------------------------
exit()
  cgroup_exit()
    put_css_set_taskexit()
      atomic_dec(cgrp->count);
                                   rmdir();
      /* not safe !! */
      check_for_release(cgrp);

rcu_read_lock() can be used to make sure the cgroup is alive.

Signed-off-by: Li Zefan <lizefan@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/cgroup.c