Revert "scsi: core: return BLK_STS_OK for DID_OK in __scsi_error_from_host_byte()"
authorBart Van Assche <bart.vanassche@wdc.com>
Thu, 5 Apr 2018 17:32:59 +0000 (10:32 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 10 Apr 2018 01:31:37 +0000 (21:31 -0400)
commitcbe095e2b584623b882ebaf6c18e0b9077baa3f7
tree2e6aa30fdf07d2172f275b3773a01fcecca6796f
parent1c6b41fb92936fa5facea464d5d7cbf855966d04
Revert "scsi: core: return BLK_STS_OK for DID_OK in __scsi_error_from_host_byte()"

The description of commit e39a97353e53 is wrong: it mentions that commit
2a842acab109 introduced a bug in __scsi_error_from_host_byte() although that
commit did not change the behavior of that function.  Additionally, commit
e39a97353e53 introduced a bug: it causes commands that fail with
hostbyte=DID_OK and driverbyte=DRIVER_SENSE to be completed with
BLK_STS_OK. Hence revert that commit.

Fixes: e39a97353e53 ("scsi: core: return BLK_STS_OK for DID_OK in __scsi_error_from_host_byte()")
Reported-by: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Douglas Gilbert <dgilbert@interlog.com>
Cc: Damien Le Moal <damien.lemoal@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Lee Duncan <lduncan@suse.com>
Cc: stable@vger.kernel.org
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_lib.c