s390/mem_detect: do not update output parameters on failure
authorAlexander Gordeev <agordeev@linux.ibm.com>
Wed, 25 Jan 2023 18:16:10 +0000 (19:16 +0100)
committerHeiko Carstens <hca@linux.ibm.com>
Tue, 31 Jan 2023 17:56:36 +0000 (18:56 +0100)
commitcbc29f107e51b1cc7d1e7b0bbe0691a1224205f1
tree674a19545b29fa14aeb905f61785eb6edb5db333
parent0c6924c262e819c4997b9cae0df6bd6e7b0b8754
s390/mem_detect: do not update output parameters on failure

Function __get_mem_detect_block() resets start and end
output parameters in case of invalid mem_detect array
index is provided. That violates the rule of sparing
the output on fail path and leads e.g to a below anomaly:

for_each_mem_detect_block(i, &start, &end)
continue;

One would expect start and end contain addresses of the
last memory block (if available), but in fact the two
will be reset to zeroes. That is not how an iterator is
expected to work.

Reviewed-by: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
arch/s390/include/asm/mem_detect.h