st/mesa: fix potential use-after-free in draw_bitmap_quad
authorMarek Olšák <marek.olsak@amd.com>
Mon, 25 Jul 2022 00:36:00 +0000 (20:36 -0400)
committerMarge Bot <emma+marge@anholt.net>
Wed, 24 Aug 2022 18:13:02 +0000 (18:13 +0000)
commitcbad4adc133b16c803ec9445c8dd144bc5023a62
treed997732da4c9aaaea7030a06c49c962f3a0410f1
parentbb860f63f6df60a00c5a97df4cb98a2e0850d3aa
st/mesa: fix potential use-after-free in draw_bitmap_quad

This is super unlikely to be freed before use, but let's fix it anyway.

setup_render_state calls set_sampler_views(take_ownership=true), which
means it takes ownership of the sampler view reference and is free to
unreference it, so we can't use sv after setup_render_state.

Fixes: feda6e9c5d101 - st/mesa: set take_ownership = true in set_sampler_views

Reviewed-by: Brian Paul <brianp@vmware.com>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17780>
src/mesa/state_tracker/st_cb_bitmap.c