ALSA: seq: Cover unsubscribe_port() in list_mutex
authorTakashi Iwai <tiwai@suse.de>
Fri, 12 Apr 2019 09:37:19 +0000 (11:37 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 Jun 2019 06:17:18 +0000 (08:17 +0200)
commitcb0c8bbd9df7d81c6b4aa5694aeb8bf0f479abd0
treee8941a0834056dc0e57225e887983536b93e0545
parent5e0c41ca896aa2487112742a76142ab84e85dc9d
ALSA: seq: Cover unsubscribe_port() in list_mutex

commit 7c32ae35fbf9cffb7aa3736f44dec10c944ca18e upstream.

The call of unsubscribe_port() which manages the group count and
module refcount from delete_and_unsubscribe_port() looks racy; it's
not covered by the group list lock, and it's likely a cause of the
reported unbalance at port deletion.  Let's move the call inside the
group list_mutex to plug the hole.

Reported-by: syzbot+e4c8abb920efa77bace9@syzkaller.appspotmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/core/seq/seq_ports.c