igb: Fix Null-pointer dereference in igb_reset_q_vector
authorChristoph Paasch <christoph.paasch@uclouvain.be>
Fri, 21 Mar 2014 10:48:19 +0000 (03:48 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Fri, 21 Mar 2014 10:48:34 +0000 (03:48 -0700)
commitcb06d102327eadcd1bdc480bfd9f8876251d1007
treea306104941b86f89fd489406b4551efadaebcf76
parent0f49da0e78f445d7a7e3e566ae4871c9428b0448
igb: Fix Null-pointer dereference in igb_reset_q_vector

When igb_set_interrupt_capability() calls
igb_reset_interrupt_capability() (e.g., because CONFIG_PCI_MSI is unset),
num_q_vectors has been set but no vector has yet been allocated.

igb_reset_interrupt_capability() will then call igb_reset_q_vector,
which assumes that the vector is allocated. As this is not the case, we
are accessing a NULL-pointer.

This patch fixes it by checking that q_vector is indeed different from
NULL.

Fixes: 02ef6e1d0b0023 (igb: Fix queue allocation method to accommodate changing during runtime)
Cc: Carolyn Wyborny <carolyn.wyborny@intel.com>
Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be>
Tested-by: Jeff Pieper <jeffrey.e.pieper@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/igb/igb_main.c