[llvm-nm] Switch command line parsing from llvm::cl to OptTable
authorFangrui Song <i@maskray.me>
Wed, 7 Jul 2021 20:34:33 +0000 (13:34 -0700)
committerFangrui Song <i@maskray.me>
Wed, 7 Jul 2021 20:34:33 +0000 (13:34 -0700)
commitcae3b831f4304d4487dd7c767ff88face51ea0dc
tree5cceab53670407b97d230669a9b38114a7cafbc1
parent8e22539067d9376c4f808b25f543feba728d40c9
[llvm-nm] Switch command line parsing from llvm::cl to OptTable

Part of https://lists.llvm.org/pipermail/llvm-dev/2021-July/151622.html
"Binary utilities: switch command line parsing from llvm::cl to OptTable"

Users should generally observe no difference as long as they only use intended
option forms. Behavior changes:

* `-t=d` is removed. Use `-t d` instead.
* `--demangle=0` cannot be used. Omit the option or use `--no-demangle` instead.
* `--help-list` is removed. This is a `cl::` specific option.

Note:

* `-t` diagnostic gets improved.
* This patch avoids cl::opt collision if we decide to support multiplexing for binary utilities
* One-dash long options are still supported.
* The `-s` collision (`-s segment section` for Mach-O) is unfortunate. `-s` means `--print-armap` in GNU nm.
* This patch removes the last `cl::multi_val` use case from the `llvm/lib/Support/CommandLine.cpp` library

`-M` (`--print-armap`), `-U` (`--defined-only`), and `-W` (`--no-weak`)
are now deprecated. They could conflict with future GNU nm options.
(--print-armap has an existing alias -s, so GNU will unlikely add a new one.
--no-weak (not in GNU nm) is rarely used anyway.)

`--just-symbol-name` is now deprecated in favor of
`--format=just-symbols` and `-j`.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D105330
14 files changed:
llvm/docs/CommandGuide/llvm-nm.rst
llvm/docs/ReleaseNotes.rst
llvm/test/Object/nm-universal-binary.test
llvm/test/tools/llvm-nm/X86/radix.s
llvm/test/tools/llvm-nm/format-bsd.test
llvm/test/tools/llvm-nm/format-sysv-layout.test
llvm/test/tools/llvm-nm/help.test
llvm/test/tools/llvm-nm/just-symbols.test
llvm/test/tools/llvm-nm/libtool-version.test
llvm/tools/llvm-nm/CMakeLists.txt
llvm/tools/llvm-nm/Opts.td [new file with mode: 0644]
llvm/tools/llvm-nm/llvm-nm.cpp
llvm/utils/gn/secondary/llvm/tools/llvm-nm/BUILD.gn
utils/bazel/llvm-project-overlay/llvm/BUILD.bazel