[Chromium] Cleanup of WebPopupMenuImpl
authortkent@chromium.org <tkent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 27 Jan 2012 04:48:24 +0000 (04:48 +0000)
committertkent@chromium.org <tkent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 27 Jan 2012 04:48:24 +0000 (04:48 +0000)
commitcae3b37ac4523e95a97c3234de5b44420eec7285
treef6f6374c507396edb746dad27c21e0d154158c25
parent731a8c695b3594b720396491c310111d6cc6e144
[Chromium] Cleanup of WebPopupMenuImpl
https://bugs.webkit.org/show_bug.cgi?id=76441

Reviewed by Kentaro Hara.

Removed WebPopupMenuImpl::invalidateContents() and scrollRectIntoView()
because they were removed from HostWindow in r58445 and r55864. They
were found by OVERRIDE.

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::popupOpened): Rename WebPopupMenuImpl::Init().
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::WebPopupMenuImpl): Update a comment.
(WebKit::WebPopupMenuImpl::init): Renamed from Init(). Update a comment.
(WebKit::WebPopupMenuImpl::handleMouseMove): Prepend "handle" to the name.
(WebKit::WebPopupMenuImpl::handleMouseLeave): ditto.
(WebKit::WebPopupMenuImpl::handleMouseDown): ditto.
(WebKit::WebPopupMenuImpl::handleMouseUp): ditto.
(WebKit::WebPopupMenuImpl::handleMouseWheel): ditto.
(WebKit::WebPopupMenuImpl::handleGestureEvent): ditto.
(WebKit::WebPopupMenuImpl::handleTouchEvent): ditto.
(WebKit::WebPopupMenuImpl::handleKeyEvent): ditto.
(WebKit::WebPopupMenuImpl::close): Update a comment.
(WebKit::WebPopupMenuImpl::composite): Remove a unused argument name.
(WebKit::WebPopupMenuImpl::handleInputEvent): Update a comment. Update callsites for handle*().
(WebKit::WebPopupMenuImpl::setFocus): Remove a unused argument name.
(WebKit::WebPopupMenuImpl::setComposition): ditto.
(WebKit::WebPopupMenuImpl::confirmComposition): ditto.
(WebKit::WebPopupMenuImpl::setTextDirection): ditto.
(WebKit::WebPopupMenuImpl::scroll): Unfold folded lines.
* src/WebPopupMenuImpl.h:
 - Remove useless argument names.
 - Add OVERRIDE.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/src/ChromeClientImpl.cpp
Source/WebKit/chromium/src/WebPopupMenuImpl.cpp
Source/WebKit/chromium/src/WebPopupMenuImpl.h