RDMA/cxgb4: remove unnecessary NULL check in __c4iw_poll_cq_one()
authorAlexey Kodanev <aleksei.kodanev@bell-sw.com>
Thu, 15 Dec 2022 12:30:30 +0000 (15:30 +0300)
committerLeon Romanovsky <leon@kernel.org>
Tue, 27 Dec 2022 13:27:59 +0000 (15:27 +0200)
commitcab30a98352511c0cb3ab6deb5d06b55fe4eb10a
tree06b5565265496ede891913817daacf417673fa3f
parent1b8ba6e41f11fc6ad4e561e0de35075256ec207c
RDMA/cxgb4: remove unnecessary NULL check in __c4iw_poll_cq_one()

If 'qhp' is NULL then 'wq' is also NULL:

    struct t4_wq *wq = qhp ? &qhp->wq : NULL;
    ...
    ret = poll_cq(wq, ...);
    if (ret)
        goto out;

poll_cq(wq, ...) always returns a non-zero status if 'wq' is NULL,
either on a t4_next_cqe() error or on a 'wq == NULL' check.

Therefore, checking 'qhp' again after poll_cq() is redundant.

BTW, there're also 'qhp' dereference cases below poll_cq() without
any checks (c4iw_invalidate_mr(qhp->rhp,...)).

Detected using the static analysis tool - Svace.

Fixes: 4ab39e2f98f2 ("RDMA/cxgb4: Make c4iw_poll_cq_one() easier to analyze")
Signed-off-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
Link: https://lore.kernel.org/r/20221215123030.155378-1-aleksei.kodanev@bell-sw.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/hw/cxgb4/cq.c