[sanitizer] Make __sanitizer::CheckFailed not public
authorKostya Kortchinsky <kostyak@google.com>
Thu, 20 Sep 2018 14:50:06 +0000 (14:50 +0000)
committerKostya Kortchinsky <kostyak@google.com>
Thu, 20 Sep 2018 14:50:06 +0000 (14:50 +0000)
commitcaa9619bcef4e67f5c2d4603b1d67c4cca6cacd8
tree255de32303966c0ae6d0d07bc057d9bc0a2a923b
parent0ff51d81b7aced65f6958c78ad3dceba0a3f6d9f
[sanitizer] Make __sanitizer::CheckFailed not public

Summary:
As far as I can tell, there is no reason why `__sanitizer::CheckFailed` should
be exported. Looking back in time, it was added with the FIXME with the
following by @timurrrr:

```
[*San/RTL] Fix minor breakage
Grumbling: this hasn't been caught by running 'make check-{a,l,t}san check-sanitizer'
```

I can't find any detail about the breakage, all tests seem to work for me, so
maybe Windows (@rnk?) or something I have no setup for.

The reason to make it private (past the FIXME) is that Scudo defines its own
(without callback) and I am trying to make the .so be loadable with the UBsan
one (that has its own public `CheckFailed`) with as little drama as possible.

Reviewers: eugenis, rnk

Reviewed By: eugenis, rnk

Subscribers: kubamracek, delcypher, #sanitizers, timurrrr, rnk, llvm-commits

Differential Revision: https://reviews.llvm.org/D52279

llvm-svn: 342651
compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h