ALSA: echoaudio: Fix potential Oops in snd_echo_resume()
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Thu, 13 Aug 2020 07:46:30 +0000 (15:46 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Aug 2020 09:02:11 +0000 (11:02 +0200)
commitca95679afe94c0464a0f30dfb554acbb97688c82
treee516b0aec686f10081119b96c1ef4b3c85c3848b
parent2a428481c8fe48e857ce19344a0786509d1da4eb
ALSA: echoaudio: Fix potential Oops in snd_echo_resume()

[ Upstream commit 5a25de6df789cc805a9b8ba7ab5deef5067af47e ]

Freeing chip on error may lead to an Oops at the next time
the system goes to resume. Fix this by removing all
snd_echo_free() calls on error.

Fixes: 47b5d028fdce8 ("ALSA: Echoaudio - Add suspend support #2")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20200813074632.17022-1-dinghao.liu@zju.edu.cn
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/pci/echoaudio/echoaudio.c