Initial Crossgen2 fixes for composite R2R support (#31652)
authorTomáš Rylek <trylek@microsoft.com>
Mon, 3 Feb 2020 23:19:21 +0000 (00:19 +0100)
committerGitHub <noreply@github.com>
Mon, 3 Feb 2020 23:19:21 +0000 (00:19 +0100)
commitca86075358d99796383e095d2a7fff6fd9e17ff0
treeaa8a494e3ff829807e0a750ba46322bf1b248d5d
parentbe3ebf6db06a374f32032a2755fa3beb59e892de
Initial Crossgen2 fixes for composite R2R support (#31652)

With initial local changes to enable composite R2R I have finally
been able to compile a CoreCLR unit test in this mode. It doesn't
yet work at runtime, these changes just fix initial compiler issues
I hit during the build:

1) Delegate constructor signature was missing some comparison logic
that ended up asserting in the node comparer in the composite
build.

2) I have removed two seeminly superfluous parameters to
CreateMethodEntrypointNodeHelper.

3) I have removed an assertion related to multi-file RVA fields
that I believe to be no longer relevant after the refactorings
to copy the RVA fields around properly.

Thanks

Tomas
src/coreclr/src/tools/crossgen2/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/DelegateCtorSignature.cs
src/coreclr/src/tools/crossgen2/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRunCodegenNodeFactory.cs