afs: Fix fileserver probe RTT handling
authorDavid Howells <dhowells@redhat.com>
Mon, 28 Nov 2022 22:02:56 +0000 (22:02 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 29 Nov 2022 02:40:07 +0000 (18:40 -0800)
commitca57f02295f188d6c65ec02202402979880fa6d8
treef07b10e0876285ea7174fd79bf91aa947d089ed4
parent4009166c3918ccfbf4daf0790630261153d6b646
afs: Fix fileserver probe RTT handling

The fileserver probing code attempts to work out the best fileserver to
use for a volume by retrieving the RTT calculated by AF_RXRPC for the
probe call sent to each server and comparing them.  Sometimes, however,
no RTT estimate is available and rxrpc_kernel_get_srtt() returns false,
leading good fileservers to be given an RTT of UINT_MAX and thus causing
the rotation algorithm to ignore them.

Fix afs_select_fileserver() to ignore rxrpc_kernel_get_srtt()'s return
value and just take the estimated RTT it provides - which will be capped
at 1 second.

Fixes: 1d4adfaf6574 ("rxrpc: Make rxrpc_kernel_get_srtt() indicate validity")
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Marc Dionne <marc.dionne@auristor.com>
Tested-by: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
Link: https://lore.kernel.org/r/166965503999.3392585.13954054113218099395.stgit@warthog.procyon.org.uk/
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/afs/fs_probe.c