mfd: intel-lpss: Fix too early PM enablement in the ACPI ->probe()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 1 Nov 2021 19:00:08 +0000 (21:00 +0200)
committerLee Jones <lee.jones@linaro.org>
Mon, 29 Nov 2021 13:17:00 +0000 (13:17 +0000)
commitc9e143084d1a602f829115612e1ec79df3727c8b
tree4a8c8056c285c15af2cd3866fb83eea799d5837d
parent17247821ae9b40ea6df8d771cfca97d91675be93
mfd: intel-lpss: Fix too early PM enablement in the ACPI ->probe()

The runtime PM callback may be called as soon as the runtime PM facility
is enabled and activated. It means that ->suspend() may be called before
we finish probing the device in the ACPI case. Hence, NULL pointer
dereference:

  intel-lpss INT34BA:00: IRQ index 0 not found
  BUG: kernel NULL pointer dereference, address: 0000000000000030
  ...
  Workqueue: pm pm_runtime_work
  RIP: 0010:intel_lpss_suspend+0xb/0x40 [intel_lpss]

To fix this, first try to register the device and only after that enable
runtime PM facility.

Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
Reported-by: Orlando Chamberlain <redecorating@protonmail.com>
Reported-by: Aditya Garg <gargaditya08@live.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Aditya Garg <gargaditya08@live.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20211101190008.86473-1-andriy.shevchenko@linux.intel.com
drivers/mfd/intel-lpss-acpi.c