crypto: chacha20poly1305 - prevent integer overflow on large input
authorJason A. Donenfeld <Jason@zx2c4.com>
Thu, 6 Feb 2020 11:42:01 +0000 (12:42 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 14 Feb 2020 06:48:37 +0000 (14:48 +0800)
commitc9cc0517bba9f0213f1e55172feceb99e5512daf
treeb6c2154760a9ccc9e2ebba416625203ad66aa542
parent872d92dec353a8d30fa186892cd5ea3e17ca75d3
crypto: chacha20poly1305 - prevent integer overflow on large input

This code assigns src_len (size_t) to sl (int), which causes problems
when src_len is very large. Probably nobody in the kernel should be
passing this much data to chacha20poly1305 all in one go anyway, so I
don't think we need to change the algorithm or introduce larger types
or anything. But we should at least error out early in this case and
print a warning so that we get reports if this does happen and can look
into why anybody is possibly passing it that much data or if they're
accidently passing -1 or similar.

Fixes: d95312a3ccc0 ("crypto: lib/chacha20poly1305 - reimplement crypt_from_sg() routine")
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: stable@vger.kernel.org # 5.5+
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
lib/crypto/chacha20poly1305.c