cpufreq: speedstep: remove unnecessary static in speedstep_detect_chipset()
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Wed, 5 Jul 2017 03:09:21 +0000 (22:09 -0500)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Sun, 16 Jul 2017 00:12:35 +0000 (02:12 +0200)
commitc95a05f9f359c895dc6bd63862923ceba059ef22
treea64f6a3fe6d19667becb7720a6830e8220415d4f
parent5771a8c08880cdca3bfb4a3fc6d309d6bba20877
cpufreq: speedstep: remove unnecessary static in speedstep_detect_chipset()

Remove unnecessary static on local variable hostbridge.
Such variable is initialized before being used,
on every execution path throughout the function.
The static has no benefit and, removing it reduces
the code size.

This issue was detected using Coccinelle and the following semantic patch:

@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
 T x@p;
 ... when != x
     when strict
?x = e;

In the following log you can see the difference in the code size. Also,
there is a significant difference in the bss segment. This log is the
output of the size command, before and after the code change:

before:
   text    data     bss     dec     hex filename
   5084    3392     256    8732    221c drivers/cpufreq/speedstep-ich.o

after:
   text    data     bss     dec     hex filename
   5062    3304     192    8558    216e drivers/cpufreq/speedstep-ich.o

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/speedstep-ich.c