Fix internal error when saving fast tracepoint definitions
authorSimon Marchi <simon.marchi@ericsson.com>
Mon, 23 Nov 2015 23:47:09 +0000 (18:47 -0500)
committerSimon Marchi <simon.marchi@ericsson.com>
Mon, 23 Nov 2015 23:47:09 +0000 (18:47 -0500)
commitc93e8391bf595de7adde64d1b3f1d564da6f3aee
tree702b8affbc88020c0b8298f481ad8ebe9cb9a4a1
parent045ccf910b4345a1cfa9f3d3af20ae4d8d1defa2
Fix internal error when saving fast tracepoint definitions

When trying to save fast tracepoints to file, gdb returns internal failure:

  gdb/breakpoint.c:13446: internal-error: unhandled tracepoint type 27
  A problem internal to GDB has been detected, further debugging may prove unreliable.

And no file including the fast tracepoints definition is created.

The patch also extends save-trace.exp to test saving tracepoint with a
fast tracepoint in there.  Note that because this test doesn't actually
inserts the tracepoints in the program, we can run it with targets that
don't actually support fast tracepoints (or tracepoints at all).

gdb/ChangeLog:

* breakpoint.c (tracepoint_print_recreate): Fix logic error
if -> else if.

gdb/testsuite/ChangeLog:

* gdb.trace/actions.c: Include trace-common.h.
(main): Add a location for a fast tracepoint.
* gdb.trace/save-trace.exp: Set a fast tracepoint in addition to
the normal tracepoints.
(gdb_verify_tracepoints): Adjust number of expected tracepoints.
gdb/ChangeLog
gdb/breakpoint.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.trace/actions.c
gdb/testsuite/gdb.trace/save-trace.exp