cachefiles: fix error return code in cachefiles_ondemand_copen()
authorSun Ke <sunke32@huawei.com>
Fri, 26 Aug 2022 02:35:15 +0000 (10:35 +0800)
committerDavid Howells <dhowells@redhat.com>
Wed, 31 Aug 2022 15:41:10 +0000 (16:41 +0100)
commitc93ccd63b18c8d108c57b2bb0e5f3b058b9d2029
treea51476e5c59a531a3ecd4aa01163c462e8f62bb0
parentec1bd37123c607ca6485beb4542a792a4db765aa
cachefiles: fix error return code in cachefiles_ondemand_copen()

The cache_size field of copen is specified by the user daemon.
If cache_size < 0, then the OPEN request is expected to fail,
while copen itself shall succeed. However, returning 0 is indeed
unexpected when cache_size is an invalid error code.

Fix this by returning error when cache_size is an invalid error code.

Changes
=======
v4: update the code suggested by Dan
v3: update the commit log suggested by Jingbo.

Fixes: c8383054506c ("cachefiles: notify the user daemon when looking up cookie")
Signed-off-by: Sun Ke <sunke32@huawei.com>
Suggested-by: Jeffle Xu <jefflexu@linux.alibaba.com>
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20220818111935.1683062-1-sunke32@huawei.com/
Link: https://lore.kernel.org/r/20220818125038.2247720-1-sunke32@huawei.com/
Link: https://lore.kernel.org/r/20220826023515.3437469-1-sunke32@huawei.com/
fs/cachefiles/ondemand.c