firmware: Fix fw_rw_offset computation in fw_base.S
authorJessica Clarke <jrtc27@jrtc27.com>
Thu, 26 Jan 2023 15:40:03 +0000 (21:10 +0530)
committerAnup Patel <anup@brainfault.org>
Fri, 27 Jan 2023 03:09:49 +0000 (08:39 +0530)
commitc8ea836ee33eb778f48f780412e147386dac5301
treeb489571d9473a46de62fff6dc422821313f1a4f5
parentc45992cc2b121e05c74b438462b8066de3e7d999
firmware: Fix fw_rw_offset computation in fw_base.S

It seems BFD just does totally nonsensical things for SHN_ABS symbols
when producing position-independent outputs (both -pie and -shared)
for various historical reasons, and so SHN_ABS symbols are still
subject to relocation as far as BFD is concerned (except AArch64,
which fixes it in limited cases that don’t apply here...).

The above affects the _fw_rw_offset provided through fw_base.ldS
linker script which results in OpenSBI firmware failing to boot
when loaded at an address different from FW_TEXT_START.

Fixes: c10e3fe5f9a1 ("firmware: Add RW section offset in scratch")
Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
Reported-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Tested-by: Anup Patel <apatel@ventanamicro.com>
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
firmware/fw_base.S
firmware/fw_base.ldS