[lldb] Remove use of ConstString from Args::GetShellSafeArgument
authorAlex Langford <alangford@apple.com>
Sat, 15 Apr 2023 00:13:55 +0000 (17:13 -0700)
committerAlex Langford <alangford@apple.com>
Mon, 17 Apr 2023 22:15:36 +0000 (15:15 -0700)
commitc8bb7c234c6814b80e2be27eba9718de7ab1ad79
tree3cd4859631f523dc14fa5d035a611974190e63b7
parent43ac269bdd00d709005f8f3550db6b657b2bf940
[lldb] Remove use of ConstString from Args::GetShellSafeArgument

Having the names of various shells in ConstString's StringPool is not
really necessary, especially if they are otherwise not going to be there
in the first place. For example, if the person debugging uses bash on
their system, the `shell` parameter will have its `m_filename` set to a
ConstString containing "bash". However, fish, tcsh, zsh, and sh will
probably never be used and are just taking up space in the StringPool.

Differential Revision: https://reviews.llvm.org/D148402
lldb/source/Utility/Args.cpp