tracepoint: Fix race between tracing and removing tracepoint
authorAlexey Kardashevskiy <aik@ozlabs.ru>
Tue, 2 Feb 2021 07:23:26 +0000 (18:23 +1100)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Tue, 2 Feb 2021 14:32:02 +0000 (09:32 -0500)
commitc8b186a8d54d7e12d28e9f9686cb00ff18fc2ab2
tree80a96646eed83f2690c2d8ac596b04d009b69ace
parent0188b87899ffc4a1d36a0badbe77d56c92fd91dc
tracepoint: Fix race between tracing and removing tracepoint

When executing a tracepoint, the tracepoint's func is dereferenced twice -
in __DO_TRACE() (where the returned pointer is checked) and later on in
__traceiter_##_name where the returned pointer is dereferenced without
checking which leads to races against tracepoint_removal_sync() and
crashes.

This adds a check before referencing the pointer in tracepoint_ptr_deref.

Link: https://lkml.kernel.org/r/20210202072326.120557-1-aik@ozlabs.ru
Cc: stable@vger.kernel.org
Fixes: d25e37d89dd2f ("tracepoint: Optimize using static_call()")
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
include/linux/tracepoint.h