[Darwin, machopic 6/n] Fix for 67183
authorIain Sandoe <iain@sandoe.co.uk>
Sat, 12 Oct 2019 19:41:50 +0000 (19:41 +0000)
committerIain Sandoe <iains@gcc.gnu.org>
Sat, 12 Oct 2019 19:41:50 +0000 (19:41 +0000)
commitc89d7d19a2aa333684e5bf744ae3b813c6054d63
treef7e3a9fbf75e71b2768e3dc87a3e9d3934a3e236
parent1aea083d4bfb7538499eae0271dae740e7efa240
[Darwin, machopic 6/n] Fix for 67183

When we're using the LLVM-based assembler (the default on modern Darwin)
the ordering of stubs and non-lazy symbol pointers is important.

Interleaving the output (current GCC behaviour) leads to crashes which
prevents us from building code with symbol stubs.

To resolve this, we order the output of stubs and symbol indirections:

 1. Any indirections in the data section
 2. Symbol stubs.
 3. Non-lazy symbol pointers.

At present, we still emit LTO sections after these.

gcc/ChangeLog:

2019-10-12  Iain Sandoe  <iain@sandoe.co.uk>

PR target/67183
* config/darwin.c (machopic_indirection): New field to flag
non-lazy-symbol-pointers in the data section.
(machopic_indirection_name): Compute if an indirection should
appear in the data section.
(machopic_output_data_section_indirection): New callback split
from machopic_output_indirection.
(machopic_output_stub_indirection): Likewise.
(machopic_output_indirection): Retain the code for non-lazy
symbol pointers in their regular section.
(machopic_finish): Use the new callbacks to order the indirection
output.

From-SVN: r276926
gcc/ChangeLog
gcc/config/darwin.c