i2c: stm32f7: Fix PEC handling in case of SMBUS transfers
authorAlain Volmat <alain.volmat@foss.st.com>
Tue, 10 Oct 2023 08:44:54 +0000 (10:44 +0200)
committerWolfram Sang <wsa@kernel.org>
Sat, 21 Oct 2023 18:31:04 +0000 (20:31 +0200)
commitc896ff2dd8f30a6b0a922c83a96f6d43f05f0e92
tree483f75a8e4df0545fe4813f25d4ceb72240b9ef3
parent3dc0ec46f6e7511fc4fdf6b6cda439382bc957f1
i2c: stm32f7: Fix PEC handling in case of SMBUS transfers

In case of SMBUS byte read with PEC enabled, the whole transfer
is split into two commands.  A first write command, followed by
a read command.  The write command does not have any PEC byte
and a PEC byte is appended at the end of the read command.
(cf Read byte protocol with PEC in SMBUS specification)

Within the STM32 I2C controller, handling (either sending
or receiving) of the PEC byte is done via the PECBYTE bit in
register CR2.

Currently, the PECBYTE is set at the beginning of a transfer,
which lead to sending a PEC byte at the end of the write command
(hence losing the real last byte), and also does not check the
PEC byte received during the read command.

This patch corrects the function stm32f7_i2c_smbus_xfer_msg
in order to only set the PECBYTE during the read command.

Fixes: 9e48155f6bfe ("i2c: i2c-stm32f7: Add initial SMBus protocols support")
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@foss.st.com>
Acked-by: Andi Shyti <andi.shyti@kernel.org>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-stm32f7.c