NSS: Replace exported NSS lookup functions with stubs [BZ #21962]
authorFlorian Weimer <fweimer@redhat.com>
Mon, 14 Aug 2017 15:12:05 +0000 (17:12 +0200)
committerFlorian Weimer <fweimer@redhat.com>
Mon, 14 Aug 2017 16:13:42 +0000 (18:13 +0200)
commitc88ffc239e8d8820f6d1d4e185984e6093a1e4d7
tree9702ec03e78de2550e98d6e5a75b8f7b218bcd7c
parent2a124c616384f140a21ee675b3e6799f8e0e7592
NSS: Replace exported NSS lookup functions with stubs [BZ #21962]

Commit 384ca551743318bd9c9e24a496d6397f2e3f2a49 from 2007 added this to
nss/XXX-lookup.c:

+#ifndef NO_COMPAT
+int
+internal_function attribute_compat_text_section
+DB_COMPAT_FCT (service_user **ni, const char *fct_name, void **fctp)
+{
+  return DB_LOOKUP_FCT (ni, fct_name, NULL, fctp);
+}
+#endif

That is, it adds a pseudo-compat function with an internal_function
attribute.  The function it was supposed to replace did not have the
attribute:

 extern int DB_LOOKUP_FCT (service_user **ni, const char *fct_name,
-   void **fctp) internal_function;
+   const char *fct2_name, void **fctp)
+  internal_function;

This changed the calling convention on i386 for the following
functions in the public ABI:

  __nss_passwd_lookup
  __nss_group_lookup
  __nss_hosts_lookup

This commit replaces the functions with always-failing stubs,
with true compat symbols.  Due to a happy accident, the calling
convention of the stub is identical for the internal_function
and non-internal_function case on i386.

In addition, this commit auto-generates the __nss_*_lookup2
function declarations as part of <nsswitch.h>.
13 files changed:
ChangeLog
grp/initgroups.c
inet/ether_hton.c
inet/ether_ntoh.c
inet/getnetgrent_r.c
nss/Makefile
nss/Versions
nss/XXX-lookup.c
nss/compat-lookup.c [new file with mode: 0644]
nss/nsswitch.h
nss/service-lookup.c
sunrpc/netname.c
sunrpc/publickey.c