projects / platform / upstream / llvm.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: b482e1b) | patch
Revert "[mlir] Add baseAttr to TypedArrayAttrBase."
authorAlex Zinenko <zinenko@google.com>
Thu, 23 Jan 2020 13:47:11 +0000 (14:47 +0100)
committerAlex Zinenko <zinenko@google.com>
Thu, 23 Jan 2020 13:47:11 +0000 (14:47 +0100)
commitc8695ba9cdebfc25af3312a84d91ae6f0f98487b
tree3cf058a10927fdfd9ae8620a91bcda854a73d8a3tree | snapshot
parentb482e1bfe29d135dc974bb21b87f95e95dfd605acommit | diff
Revert "[mlir] Add baseAttr to TypedArrayAttrBase."

This reverts commit eec36909c18b8788773abc95d199e6acde6eb42c.

This modeling is incorrect. baseAttr is intended for attribute
decorators that are not backed by C++ attribute classes. It essentially
says DerivedAttr isa BaseAttr, which is wrong for ArrayAttr classes.
If one needs to store the element type, it should be stored as a
separate filed in the tablegen class.
mlir/include/mlir/IR/OpBase.td diff | blob | history
Domain: System / Toolchain;