packet: fix race condition in packet_set_ring 23/102923/2 accepted/tizen/common/20161209.061456 accepted/tizen/ivi/20161209.060650 accepted/tizen/mobile/20161209.060550 accepted/tizen/tv/20161209.060608 accepted/tizen/wearable/20161209.060627 submit/tizen/20161209.020241
authorPhilip Pettersson <philip.pettersson@gmail.com>
Tue, 6 Dec 2016 23:51:56 +0000 (08:51 +0900)
committerInki Dae <inki.dae@samsung.com>
Tue, 6 Dec 2016 23:55:51 +0000 (15:55 -0800)
commiteed519ed3f25a2f54edc77a996e1a3a94a085582
tree70367dfcb3afcbaa6aa0bca306180500d3084887
parenta39019df279cbade02394a40ae69ebbebc282650
packet: fix race condition in packet_set_ring

When packet_set_ring creates a ring buffer it will initialize a
struct timer_list if the packet version is TPACKET_V3. This value
can then be raced by a different thread calling setsockopt to
set the version to TPACKET_V1 before packet_set_ring has finished.

This leads to a use-after-free on a function pointer in the
struct timer_list when the socket is closed as the previously
initialized timer will not be deleted.

The bug is fixed by taking lock_sock(sk) in packet_setsockopt when
changing the packet version while also taking the lock at the start
of packet_set_ring.

Ps. This is CVE-2016-8655 patch,
http://seclists.org/oss-sec/2016/q4/607

Change-Id: I3396f1bfe60b03082a981ae9d8a787b41cb5a529
Fixes: f6fb8f100b80 ("af-packet: TPACKET_V3 flexible buffer implementation.")
Signed-off-by: Philip Pettersson <philip.pettersson@gmail.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
net/packet/af_packet.c