i2c: rcar: avoid race when unregistering slave
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Sun, 26 Jul 2020 16:16:06 +0000 (18:16 +0200)
committerWolfram Sang <wsa@kernel.org>
Fri, 31 Jul 2020 13:56:32 +0000 (15:56 +0200)
commitc7c9e914f9a0478fba4dc6f227cfd69cf84a4063
treecc8f12cf3d9c1c91188d51d1052760d5a573d8b9
parent073d398dc4841f62488ac6060ffeb9dfce6e0a98
i2c: rcar: avoid race when unregistering slave

Due to the lockless design of the driver, it is theoretically possible
to access a NULL pointer, if a slave interrupt was running while we were
unregistering the slave. To make this rock solid, disable the interrupt
for a short time while we are clearing the interrupt_enable register.
This patch is purely based on code inspection. The OOPS is super-hard to
trigger because clearing SAR (the address) makes interrupts even more
unlikely to happen as well. While here, reinit SCR to SDBS because this
bit should always be set according to documentation. There is no effect,
though, because the interface is disabled.

Fixes: 7b814d852af6 ("i2c: rcar: avoid race when unregistering slave client")
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-rcar.c