mm/gup: Mark lock taken only after a successful retake
authorPeter Xu <peterx@redhat.com>
Wed, 8 Apr 2020 01:40:10 +0000 (21:40 -0400)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 8 Apr 2020 02:34:31 +0000 (19:34 -0700)
commitc7b6a566b98524baea6a244186e665d22b633545
tree00b778f01a2928b56a1221a1e291b06089ff8833
parentba841078cd0557b43b59c63f5c048b12168f0db2
mm/gup: Mark lock taken only after a successful retake

It's definitely incorrect to mark the lock as taken even if
down_read_killable() failed.

This wass overlooked when we switched from down_read() to
down_read_killable() because down_read() won't fail while
down_read_killable() could.

Fixes: 71335f37c5e8 ("mm/gup: allow to react to fatal signals")
Reported-by: syzbot+a8c70b7f3579fc0587dc@syzkaller.appspotmail.com
Signed-off-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/gup.c