Prevent fix-it hints from affecting more than one line
authorDavid Malcolm <dmalcolm@redhat.com>
Tue, 20 Jun 2017 10:40:38 +0000 (10:40 +0000)
committerDavid Malcolm <dmalcolm@gcc.gnu.org>
Tue, 20 Jun 2017 10:40:38 +0000 (10:40 +0000)
commitc7a980b80b3a46ad24940269f6b85a75cdb94a60
treefe86d10819506cdb8f17e6172d8ed766eb12c2fa
parentad2f2a35d33ea79f95b70f8d96ee1445fabed402
Prevent fix-it hints from affecting more than one line

Attempts to apply a removal or replacement fix-it hint to a source
range that covers multiple lines currently lead to nonsensical
results from the printing code in diagnostic-show-locus.c.

We were already filtering them out in edit-context.c (leading
to -fdiagnostics-generate-patch not generating any output for
the whole TU).

Reject attempts to add such fix-it hints within rich_location,
fixing the diagnostic-show-locus.c issue.

gcc/ChangeLog:
* diagnostic-show-locus.c
(selftest::test_fixit_deletion_affecting_newline): New function.
(selftest::diagnostic_show_locus_c_tests): Call it.

libcpp/ChangeLog:
* include/line-map.h (class rich_location): Document that attempts
to delete or replace a range *affecting* multiple lines will fail.
* line-map.c (rich_location::maybe_add_fixit): Implement this
restriction.

From-SVN: r249403
gcc/ChangeLog
gcc/diagnostic-show-locus.c
libcpp/ChangeLog
libcpp/include/line-map.h
libcpp/line-map.c