[clang] Remove overly restrictive aggregate paren init logic
authorAlan Zhao <ayzhao@google.com>
Mon, 19 Dec 2022 18:04:06 +0000 (10:04 -0800)
committerAlan Zhao <ayzhao@google.com>
Wed, 21 Dec 2022 16:21:05 +0000 (08:21 -0800)
commitc77a91bb7ba793ec3a6a5da3743ed55056291658
treeedd491c1f2cbb27376daa9fe1b41af65fdf5180f
parent0bca44680ab9dc83a372a6bf932d42dfb24fbf4d
[clang] Remove overly restrictive aggregate paren init logic

Previously, we would only attempt to perform a parenthesized aggregate
initialization if constructor initialization failed for only the default
constructor, default copy constructor, and default move constructor. The
original intent of this logic was to reject initializing objects that
have failed resolving a user-defined constructor. However, this check is
redundant because we check for isAggregate() before attempting to
perform a parenthesized aggregate initialization, and classes that have
user-defined or user-declared constructors are not aggregates.
Furthermore, this check is too restrictive - the following valid
examples fail:
* Aggregate class with user-defined destructor - fails because default
  move constructors are not generated for classes with user-defined
  destructors
  (https://github.com/llvm/llvm-project/issues/54040#issuecomment-1356926048)
* Concept-guarded conversion operator on an aggregate's member:
  (https://github.com/llvm/llvm-project/issues/54040#issuecomment-1356931745)

The solution therefore is to remove this logic; existing tests still
pass, and the previously failing examples now compile.

Reviewed By: ilya-biryukov

Differential Revision: https://reviews.llvm.org/D140327
clang/lib/Sema/SemaInit.cpp
clang/test/CodeGen/paren-list-agg-init.cpp