selftests/riscv: fix potential build failure during the "emit_tests" step
authorJohn Hubbard <jhubbard@nvidia.com>
Wed, 12 Jul 2023 19:35:14 +0000 (12:35 -0700)
committerShuah Khan <skhan@linuxfoundation.org>
Fri, 14 Jul 2023 18:32:42 +0000 (12:32 -0600)
commitc77896b143d3c9c3e84c4ed0662b807ccbd8730b
treee2b3328ab8eeef10f05c9bf8db123bbc373a8908
parente8b03aef194c3c8597f4fb8e58ade1cc1f43001e
selftests/riscv: fix potential build failure during the "emit_tests" step

The riscv selftests (which were modeled after the arm64 selftests) are
improperly declaring the "emit_tests" target to depend upon the "all"
target. This approach, when combined with commit 9fc96c7c19df
("selftests: error out if kernel header files are not yet built"), has
caused build failures [1] on arm64, and is likely to cause similar
failures for riscv.

To fix this, simply remove the unnecessary "all" dependency from the
emit_tests target. The dependency is still effectively honored, because
again, invocation is via "install", which also depends upon "all".

An alternative approach would be to harden the emit_tests target so that
it can depend upon "all", but that's a lot more complicated and hard to
get right, and doesn't seem worth it, especially given that emit_tests
should probably not be overridden at all.

[1] https://lore.kernel.org/20230710-kselftest-fix-arm64-v1-1-48e872844f25@kernel.org

Fixes: 9fc96c7c19df ("selftests: error out if kernel header files are not yet built")
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Tested-by: Alexandre Ghiti <alexghiti@rivosinc.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/selftests/riscv/Makefile