projects / platform / upstream / gst-plugins-good.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: d146971) | patch
ebml: Validate 7-bit ASCII in gst_ebml_read_ascii
authorPhilip Jägenstedt <philipj@opera.com>
Wed, 12 May 2010 11:16:28 +0000 (13:16 +0200)
committerSebastian Dröge <sebastian.droege@collabora.co.uk>
Wed, 19 May 2010 18:33:38 +0000 (20:33 +0200)
commitc712d2879655ecf0e503e06cd32eb058ef1af047
treee235a2b7a007318a2c7f6bcfa17f6409545c5e32tree | snapshot
parentd14697112864f385e0a341cde6533f9e22d04c36commit | diff
ebml: Validate 7-bit ASCII in gst_ebml_read_ascii

This was triggering an UTF-8 assertion in gst_caps_set_simple for
corrupt files with garbage as codec id. Test case:
gstreamer_error_trying_to_set_invalid_utf8_as_codec_id.webm

Old gst_ebml_read_ascii renamed to gst_ebml_read_string, also used by
gst_ebml_read_utf8. Unlike for UTF-8, failure to validate is an error,
as gst_ebml_read_ascii is used for reading doctype and codec id and we
might just as well give up early in those cases.
gst/matroska/ebml-read.c diff | blob | history
Domain: Multimedia / Media Common;