Change build_address_symbolic to return std::string
authorTom Tromey <tom@tromey.com>
Sat, 5 May 2018 16:24:54 +0000 (10:24 -0600)
committerTom Tromey <tom@tromey.com>
Thu, 7 Jun 2018 12:38:18 +0000 (06:38 -0600)
commitc7110220be62590222e35525dda499902ee49a89
tree34756b1adffc595768d9c9d9e3c8197aefed0af5
parent2a9b2c1abe29e1063240604d2464b8de9a46011f
Change build_address_symbolic to return std::string

This changes two out parameters of build_address_symbolic to be
std::string, and updates the callers.  This allows removing some
cleanups.

This patch also moves the declaration of build_address_symbolic out of
defs.h.  I think that many things in defs.h should be elsewhere
instead.  In this case, I moved the declaration to valprint.h, becuase
there is no "printcmd.h" -- but perhaps it would be better to
introduce that instead.

Tested by the buildbot.

gdb/ChangeLog
2018-06-07  Tom Tromey  <tom@tromey.com>

* valprint.h (build_address_symbolic): Declare.
* printcmd.c (print_address_symbolic): Update.
(build_address_symbolic): Change "name" and "filename" to
std::string.
* disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
Update.
* defs.h (build_address_symbolic): Remove declaration.
gdb/ChangeLog
gdb/defs.h
gdb/disasm.c
gdb/printcmd.c
gdb/valprint.h