blockdev: Fix NULL pointer dereference in blockdev-add
authorKevin Wolf <kwolf@redhat.com>
Thu, 6 Mar 2014 14:47:32 +0000 (15:47 +0100)
committerKevin Wolf <kwolf@redhat.com>
Thu, 6 Mar 2014 16:27:28 +0000 (17:27 +0100)
commitc6e0bd9b7037937aafeb1d34ec17975a7d685bb7
tree0343add7aadc0202fae6a1b6c3e2766c995696f7
parent8ae8e904fcba484ff7c3f8f31339b56ebd88fbad
blockdev: Fix NULL pointer dereference in blockdev-add

If aio=native, we check that cache.direct is set as well. If however
cache wasn't specified at all, qemu just segfaulted.

The old condition didn't make any sense anyway because it effectively
only checked for the default cache mode case, but not for an explicitly
set cache.direct=off mode.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Reviewed-by: Eric Blake <eblake@redhat.com>
blockdev.c