staging: r8188eu: clean up NULL check for rcu pointer
authorMartin Kaiser <martin@kaiser.cx>
Tue, 31 Jan 2023 09:00:57 +0000 (10:00 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 6 Feb 2023 09:44:38 +0000 (10:44 +0100)
commitc6dd307144235f2abd97c974883398176345af9f
tree89e0ca24dfe78d06153ccbf82719db5ac662ae5d
parent7f0c12449aa91867efb00f080fb34c77d40c81e6
staging: r8188eu: clean up NULL check for rcu pointer

Clean up the NULL check for padapter->pnetdev->rx_handler_data.

The current code calls rcu_dereference while it holds the rcu read lock
and checks the pointer after releasing the lock. An rcu pointer may only be
used between calls to rcu_read_lock and rcu_read_unlock.

Replace the check with rcu_access_pointer. My understanding is that this
function returns the value of the pointer and needs no locking. We can
then check the pointer but we must not dereference it.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20230131090057.241779-1-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_xmit.c