powerpc/rtas: clean up rtas_error_log_max initialization
authorNathan Lynch <nathanl@linux.ibm.com>
Fri, 18 Nov 2022 15:07:44 +0000 (09:07 -0600)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 7 Dec 2022 11:40:42 +0000 (22:40 +1100)
commitc67a0e411d0ffe0648fe84e25e9f899ce770feb3
treeda7ef2a1bbe78b18f9a3254052950a565432a53b
parent9aafbfa5f57a4b75bafd3bed0191e8429c5fa618
powerpc/rtas: clean up rtas_error_log_max initialization

The code in rtas_get_error_log_max() doesn't cause problems in
practice, but there are no measures to ensure that the lazy
initialization of the static rtas_error_log_max variable is atomic,
and it's not worth adding them.

Initialize the static rtas_error_log_max variable at boot when we're
single-threaded instead of lazily on first use. Use the more
appropriate of_property_read_u32() API instead of rtas_token() to
consult the "rtas-error-log-max" property, which is not the name of an
RTAS function. Convert use of printk() to pr_warn() and distinguish
the possible error cases.

Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20221118150751.469393-7-nathanl@linux.ibm.com
arch/powerpc/kernel/rtas.c