drm/i915/fbc: Remember to update FBC state even when not reallocating CFB
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 16 Dec 2021 11:08:22 +0000 (13:08 +0200)
committerJani Nikula <jani.nikula@intel.com>
Mon, 27 Dec 2021 09:46:48 +0000 (11:46 +0200)
commitc65fe9cbbfd61dbc12868f9ed4940c80fcb249e8
tree9cb40b8997ba2bca8c5a9412833241954f500ee8
parent040bf2a9446f6ba267225d34dc4a9b14d11e5092
drm/i915/fbc: Remember to update FBC state even when not reallocating CFB

We mustn't forget to update our FBC state even if we don't have
to reallocate the CFB. Otherwise we won't refresh our notion
of what eg. the new fence or the new override CFB stride
should be. Using the wrong CFB stride in particular can cause
underruns and could even corrupt other stuff in stolen.

Fixes: f4cfdbb02ca8 ("drm/i915/fbc: Nuke state_cache")
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4774
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211216110822.8461-1-ville.syrjala@linux.intel.com
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
(cherry picked from commit 798c5daf3cddff3f39c5542a50a2dbd83879b05d)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_fbc.c