kbuild: make *.mod rule robust against too long argument error
authorMasahiro Yamada <masahiroy@kernel.org>
Fri, 27 May 2022 10:01:53 +0000 (19:01 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Wed, 1 Jun 2022 14:07:29 +0000 (23:07 +0900)
commitc6031b1dbbbfec03891bf1baefa2e0803d705601
tree173a64a7a43628e63041a824f6879811838b3460
parentcd968b97c49214e6557381bddddacbd0e0fb696e
kbuild: make *.mod rule robust against too long argument error

Like built-in.a, the command length of the *.mod rule scales with
the depth of the directory times the number of objects in the Makefile.

Add $(obj)/ by the shell command (awk) instead of by Make's builtin
function.

In-tree modules still have some room to the limit (ARG_MAX=2097152),
but this is more future-proof for big modules in a deep directory.

For example, you can build i915 as a module (CONFIG_DRM_I915=m) and
compare drivers/gpu/drm/i915/.i915.mod.cmd with/without this commit.

The issue is more critical for external modules because the M= path
can be very long as Jeff Johnson reported before [1].

[1] https://lore.kernel.org/linux-kbuild/4c02050c4e95e4cb8cc04282695f8404@codeaurora.org/

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64)
scripts/Makefile.build