MIPS: Fix execution hazard during watchpoint register probe
authorPaul Burton <paul.burton@imgtec.com>
Sat, 15 Jun 2013 15:34:40 +0000 (15:34 +0000)
committerRalf Baechle <ralf@linux-mips.org>
Fri, 21 Jun 2013 16:07:03 +0000 (18:07 +0200)
commitc5e1503fd0428ed3a2e5e48734f47c9f4dfe5a3d
treeeee721bec54e7e879daf8736c78cdcd0b336dcb8
parentc37441c127e000869a960a866fe2207626935e4f
MIPS: Fix execution hazard during watchpoint register probe

Writing a value to a WatchLo* register creates an execution hazard, so
if its value is then read before that hazard is cleared then said value
may be invalid. The mips_probe_watch_registers function must therefore
clear the execution hazard between setting the match bits in a WatchLo*
register & reading the register back in order to check which are set.

This fixes intermittent incorrect watchpoint register probing on some
MIPS cores such as interAptiv & proAptiv.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Acked-by: Steven J. Hill <Steven.Hill@imgtec.com>
Cc: linux-mips@linux-mips.org
Patchwork: http://patchwork.linux-mips.org/patch/5474/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
arch/mips/kernel/watch.c