xen/cpuhotplug: Fix initial CPU offlining for PV(H) guests
authorBoris Ostrovsky <boris.ostrovsky@oracle.com>
Fri, 8 May 2020 22:28:43 +0000 (18:28 -0400)
committerBoris Ostrovsky <boris.ostrovsky@oracle.com>
Thu, 21 May 2020 18:01:45 +0000 (13:01 -0500)
commitc54b071c192dfe8061336f650ceaf358e6386e0b
tree27b3c225e7d9b5c9a07f11607aa11f8a06fd592e
parentc17db64044e34ae6c2df56cc4837787f9d48edd5
xen/cpuhotplug: Fix initial CPU offlining for PV(H) guests

Commit a926f81d2f6c ("xen/cpuhotplug: Replace cpu_up/down() with
device_online/offline()") replaced cpu_down() with device_offline()
call which requires that the CPU has been registered before. This
registration, however, happens later from topology_init() which
is called as subsys_initcall(). setup_vcpu_hotplug_event(), on the
other hand, is invoked earlier, during arch_initcall().

As result, booting a PV(H) guest with vcpus < maxvcpus causes a crash.

Move setup_vcpu_hotplug_event() (and therefore setup_cpu_watcher()) to
late_initcall(). In addition, instead of performing all offlining steps
in setup_cpu_watcher() simply call disable_hotplug_cpu().

Fixes: a926f81d2f6c (xen/cpuhotplug: Replace cpu_up/down() with device_online/offline()"
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: https://lore.kernel.org/r/1588976923-3667-1-git-send-email-boris.ostrovsky@oracle.com
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
drivers/xen/cpu_hotplug.c