ASoC: SOF: Intel: hda-dai: protect hw_params against successive calls
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thu, 21 Apr 2022 20:32:01 +0000 (15:32 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 25 Apr 2022 12:58:38 +0000 (13:58 +0100)
commitc4eb48f7739fc0dae7e6b8319a77261fc1b61d74
tree3c83162a73ba7c3691bd7d9a902ebfb9463c3d3d
parent880924cad12e96092364467cb7b3ad7a689bec55
ASoC: SOF: Intel: hda-dai: protect hw_params against successive calls

Once we've set-up the HDA stream and its format, we currently don't
support additional format changes. We already have a protection in the
.prepare case, but this needs to be added in the hw_params too.

In mixing use cases where two DPCM FEs are connected to the same BE,
if can happen that there are multiple calls to the BE hw_params when
the two FEs are configured simultaneously.

This could alternatively be fixed at the DPCM level but that's a more
intrusive change requiring infrastructure changes: this would need to
be paired with the definition of fixed hw_params at the mixer level.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20220421203201.1550328-15-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/intel/hda-dai.c