tcm_qla2xxx: Fix incorrect use of __transport_register_session
authorBart Van Assche <bart.vanassche@sandisk.com>
Fri, 20 Mar 2015 05:25:16 +0000 (22:25 -0700)
committerSasha Levin <sasha.levin@oracle.com>
Fri, 17 Apr 2015 00:11:30 +0000 (20:11 -0400)
commitc4d66c922de38e7b541ef3cf15ef71b9ed6d4206
tree62ae1864c655dd30b6a22e817a94527ecc870812
parent2223d18c6c50a83509c0ef01e0447ee182b16fe2
tcm_qla2xxx: Fix incorrect use of __transport_register_session

[ Upstream commit 75c3d0bf9caebb502e96683b2bc37f9692437e68 ]

This patch fixes the incorrect use of __transport_register_session()
in tcm_qla2xxx_check_initiator_node_acl() code, that does not perform
explicit se_tpg->session_lock when accessing se_tpg->tpg_sess_list
to add new se_sess nodes.

Given that tcm_qla2xxx_check_initiator_node_acl() is not called with
qla_hw->hardware_lock held for all accesses of ->tpg_sess_list, the
code should be using transport_register_session() instead.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Giridhar Malavali <giridhar.malavali@qlogic.com>
Cc: Quinn Tran <quinn.tran@qlogic.com>
Cc: <stable@vger.kernel.org> # 3.5+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/scsi/qla2xxx/tcm_qla2xxx.c