mt76: mt7915: fix unused 'mode' variable
authorArnd Bergmann <arnd@arndb.de>
Fri, 26 Feb 2021 14:21:27 +0000 (15:21 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Fri, 26 Feb 2021 15:35:15 +0000 (17:35 +0200)
commitc490492f15f656340b35cb9e36b9bfdea3539e19
treed710545f55238f86d9566ae40a43e45463d2700e
parentd0bd52c591a1070c54dc428e926660eb4f981099
mt76: mt7915: fix unused 'mode' variable

clang points out a possible corner case in the mt7915_tm_set_tx_cont()
function if called with invalid arguments:

drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:593:2: warning: variable 'mode' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
        default:
        ^~~~~~~
drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:597:13: note: uninitialized use occurs here
        rateval =  mode << 6 | rate_idx;
                   ^~~~
drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:506:37: note: initialize the variable 'mode' to silence this warning
        u8 rate_idx = td->tx_rate_idx, mode;
                                           ^

Change it to return an error instead of continuing with invalid data
here.

Fixes: 3f0caa3cbf94 ("mt76: mt7915: add support for continuous tx in testmode")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/mediatek/mt76/mt7915/testmode.c