Re-enable CA1802 (use consts instead of readonly statics) (dotnet/corefx#39782)
authorStephen Toub <stoub@microsoft.com>
Fri, 26 Jul 2019 02:02:21 +0000 (22:02 -0400)
committerGitHub <noreply@github.com>
Fri, 26 Jul 2019 02:02:21 +0000 (22:02 -0400)
commitc4638601c6779d9e8547be3af64218f1179904d8
tree516d1fffd8ab38bac5d895fb841c4ff040a7cebe
parent86953da4c4b0b60c58bdcf623c3ec77cb6ed1201
Re-enable CA1802 (use consts instead of readonly statics) (dotnet/corefx#39782)

* Re-enable CA1802 (use consts instead of readonly statics)

I enabled it only for privates and internals, as we've previously violated this in public surface area, and as everything goes through API review moving forward, didn't seem worthwhile fighting it and adding suppressions in various places.

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/318b5941ba4e713155d82c674c7f5bd0e68faf7b
53 files changed:
src/libraries/CodeAnalysis.ruleset
src/libraries/Common/src/System/Data/ProviderBase/TimeoutTimer.cs
src/libraries/Common/src/System/Net/Mail/MailBnfHelper.cs
src/libraries/Common/src/System/Net/SocketAddress.cs
src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ConfigurationElement.cs
src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ConfigurationProperty.cs
src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ConfigurationPropertyAttribute.cs
src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ConfigurationPropertyCollection.cs
src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/PropertyInformationCollection.cs
src/libraries/System.Data.Common/src/System/Data/Common/DecimalStorage.cs
src/libraries/System.Data.Common/src/System/Data/Common/UInt16Storage.cs
src/libraries/System.Data.Common/src/System/Data/Common/UInt32Storage.cs
src/libraries/System.Data.Common/src/System/Data/Common/UInt64Storage.cs
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLByte.cs
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLDateTime.cs
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLDecimal.cs
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLGuid.cs
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLInt16.cs
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLInt32.cs
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLInt64.cs
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLMoney.cs
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLString.cs
src/libraries/System.Data.Odbc/src/Common/System/Data/Common/AdapterUtil.Odbc.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcCommand.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcConnection.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcHandle.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcParameter.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcParameterHelper.cs
src/libraries/System.Data.SqlClient/src/System/Data/Common/AdapterUtil.SqlClient.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlCommand.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlEnums.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlParameter.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlParameterHelper.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/TdsParser.cs
src/libraries/System.IO.Packaging/src/System/IO/Packaging/InternalRelationshipCollection.cs
src/libraries/System.IO.Packaging/src/System/IO/Packaging/PackUriHelper.cs
src/libraries/System.IO.Packaging/src/System/IO/Packaging/PackagingUtilities.cs
src/libraries/System.IO.Packaging/src/System/IO/Packaging/ZipPackage.cs
src/libraries/System.Management/src/System/Management/ManagementQuery.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEngine.Unix.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/UnixDomainSocketEndPoint.Windows.cs
src/libraries/System.Net.Sockets/tests/FunctionalTests/UnixDomainSocketTest.netcoreapp.cs
src/libraries/System.Private.Xml/src/System.Private.Xml.csproj
src/libraries/System.Private.Xml/src/System/Xml/Base64Decoder.cs
src/libraries/System.Private.Xml/src/System/Xml/BinaryXml/SqlUtils.cs
src/libraries/System.Private.Xml/src/System/Xml/Bits.cs
src/libraries/System.Private.Xml/src/System/Xml/Schema/XmlUntypedStringConverter.cs
src/libraries/System.Private.Xml/src/System/Xml/XmlConvert.cs
src/libraries/System.Runtime.Caching/src/System/Runtime/Caching/PhysicalMemoryMonitor.cs
src/libraries/System.Security.AccessControl/src/System/Security/AccessControl/ACE.cs
src/libraries/System.Security.AccessControl/src/System/Security/AccessControl/ObjectSecurity.cs
src/libraries/System.Security.Principal.Windows/src/System/Security/Principal/SID.cs
src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexCharClass.cs