review.tizen.org Git - platform/upstream/dotnet/runtime.git/commit

projects / platform / upstream / dotnet / runtime.git / commit

author	Levi Broderick <GrabYourPitchforks@users.noreply.github.com>
	Tue, 7 Apr 2020 19:16:24 +0000 (12:16 -0700)
committer	GitHub <noreply@github.com>
	Tue, 7 Apr 2020 19:16:24 +0000 (12:16 -0700)
commit	c4507d795038c41fc041276e0737045262f9980d
tree	fe076855b1c14f6d2e4b6e6a987e16027488a8c7	tree \| snapshot
parent	f8d38f45e1a109a8f6895a4a6f82c4d00108e1d4	commit \| diff

Fix various LastIndexOf bugs when given zero-length target values (#34616)

- string.LastIndexOf(string.Empty) shouldn't perform -1 adjustment
- MemoryExtensions.LastIndexOf(ROS<char>, string.Empty) shouldn't return 0
- Tighten up some existing unit tests

24 files changed:

src/libraries/Common/tests/Tests/System/StringTests.cs		diff \| blob \| history
src/libraries/System.Globalization/tests/CompareInfo/CompareInfoTests.LastIndexOf.cs		diff \| blob \| history
src/libraries/System.Globalization/tests/CompareInfo/CompareInfoTests.cs		diff \| blob \| history
src/libraries/System.Globalization/tests/Invariant/InvariantMode.cs		diff \| blob \| history
src/libraries/System.Memory/tests/ReadOnlySpan/IndexOfSequence.T.cs		diff \| blob \| history
src/libraries/System.Memory/tests/ReadOnlySpan/IndexOfSequence.byte.cs		diff \| blob \| history
src/libraries/System.Memory/tests/ReadOnlySpan/LastIndexOfSequence.T.cs		diff \| blob \| history
src/libraries/System.Memory/tests/ReadOnlySpan/LastIndexOfSequence.byte.cs		diff \| blob \| history
src/libraries/System.Memory/tests/Span/IndexOfSequence.T.cs		diff \| blob \| history
src/libraries/System.Memory/tests/Span/IndexOfSequence.byte.cs		diff \| blob \| history
src/libraries/System.Memory/tests/Span/IndexOfSequence.char.cs		diff \| blob \| history
src/libraries/System.Memory/tests/Span/LastIndexOfSequence.T.cs		diff \| blob \| history
src/libraries/System.Memory/tests/Span/LastIndexOfSequence.byte.cs		diff \| blob \| history
src/libraries/System.Memory/tests/Span/LastIndexOfSequence.char.cs		diff \| blob \| history
src/libraries/System.Memory/tests/TestHelpers.cs		diff \| blob \| history
src/libraries/System.Private.CoreLib/src/System/Globalization/CompareInfo.Invariant.cs		diff \| blob \| history
src/libraries/System.Private.CoreLib/src/System/Globalization/CompareInfo.Unix.cs		diff \| blob \| history
src/libraries/System.Private.CoreLib/src/System/Globalization/CompareInfo.Windows.cs		diff \| blob \| history
src/libraries/System.Private.CoreLib/src/System/Globalization/CompareInfo.cs		diff \| blob \| history
src/libraries/System.Private.CoreLib/src/System/MemoryExtensions.Globalization.cs		diff \| blob \| history
src/libraries/System.Private.CoreLib/src/System/SpanHelpers.Byte.cs		diff \| blob \| history
src/libraries/System.Private.CoreLib/src/System/SpanHelpers.T.cs		diff \| blob \| history
src/libraries/System.Private.CoreLib/src/System/String.Comparison.cs		diff \| blob \| history
src/libraries/System.Private.CoreLib/src/System/String.Searching.cs		diff \| blob \| history

Domain: Dotnet / Core;

RSS Atom