SUNRPC: Change return value type of .pc_decode
authorChuck Lever <chuck.lever@oracle.com>
Tue, 12 Oct 2021 15:57:28 +0000 (11:57 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Wed, 13 Oct 2021 14:29:41 +0000 (10:29 -0400)
commitc44b31c263798ec34614dd394c31ef1a2e7e716e
tree3a6ed73ccf66ec7e4ec2ce54a32204c6e4e9c7e6
parent16c663642c7ec03cd4cee5fec520bb69e97babe4
SUNRPC: Change return value type of .pc_decode

Returning an undecorated integer is an age-old trope, but it's
not clear (even to previous experts in this code) that the only
valid return values are 1 and 0. These functions do not return
a negative errno, rpc_stat value, or a positive length.

Document there are only two valid return values by having
.pc_decode return only true or false.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
15 files changed:
fs/lockd/xdr.c
fs/lockd/xdr4.c
fs/nfsd/nfs2acl.c
fs/nfsd/nfs3acl.c
fs/nfsd/nfs3xdr.c
fs/nfsd/nfs4xdr.c
fs/nfsd/nfsd.h
fs/nfsd/nfssvc.c
fs/nfsd/nfsxdr.c
fs/nfsd/xdr.h
fs/nfsd/xdr3.h
fs/nfsd/xdr4.h
include/linux/lockd/xdr.h
include/linux/lockd/xdr4.h
include/linux/sunrpc/svc.h